VeraCrypt
aboutsummaryrefslogtreecommitdiff
path: root/src/Main
AgeCommit message (Collapse)AuthorFilesLines
2023-10-08Fix warnings and throwing an exception instead of ignoring the error (#1229)kovalev01-1/+0
* EMVCard.cpp: ArrayToHexWideString: prohibit conversion of a string constant ../Common/EMVCard.cpp: In function 'std::wstring VeraCrypt::ArrayToHexWideString(con st unsigned char*, size_t)': ../Common/EMVCard.cpp:28:43: warning: ISO C++ forbids converting a string constant to 'wchar_t*' [-Wwrite-strings] 28 | static wchar_t* hexChar = L"0123456789ABCDEF"; | ^~~~~~~~~~~~~~~~~~~ Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org> * EMVCard.cpp: ArrayToHexWideString: fix of the comparison of different types ../Common/EMVCard.cpp: In function 'std::wstring VeraCrypt::ArrayToHexWideString(con st unsigned char*, size_t)': ../Common/EMVCard.cpp:32:43: warning: comparison of integer expressions of different signedness: 'int' and 'size_t' {aka 'long unsigned int'} [-Wsign-compare] 32 | for (int i = 0; i < cbData; i++) | ~~^~~~~~~~ Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org> * SecurityTokenKeyfilesDialog.cpp: removed initialization of an unused variable Forms/SecurityTokenKeyfilesDialog.cpp:58:24: warning: unused variable 'i' [-Wunused- variable] 58 | size_t i = 0; | ^ Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org> * Core/Unix: throwing an exception instead of ignoring the error Fixes: 5a6b445f ("fix warnings and UB (#1164)") Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org> --------- Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org> Co-authored-by: Vasiliy Kovalev <kovalev@altlinux.org>
2023-10-05Update various copyright datesMounir IDRASSI1-5/+5
2023-10-05fix for corrupted icons (#1226)sardanap1-1/+1
2023-10-01MacOS: set minimum target to OSX 12. Fix About menu not working.Mounir IDRASSI1-0/+14
The modification to Forms.cpp is temporary until we find a better approach
2023-09-02Linux/macOS: preserve unknown entries in configuration fileMounir IDRASSI2-10/+28
This helps to preserve unknown entries that may be used by future versions of VeraCrypt (forward compatibility) or entries used by old versions that were removed from current version (backward compatibility)
2023-08-21Allow cross compilation. (#1182)Unit 1931-2/+2
2023-08-19Linux: Fix wrong max size for hidden volume in CLI direct mode creationMounir IDRASSI1-8/+15
There was a logical bug that made the code check the filesystem size of the device path "/dev" instead of using the actual size of the device Fix #1180
2023-08-12Linux: Flush stdout explicitly when reading stdin (#1172)Jertzukka1-1/+1
Rules of automatic flushing of stdout buffer is implementation-defined behaviour. In glibc this is automatically flushed, but we can't rely on it for other implementations such as musl.
2023-08-12Linux: Typo fix and consistency in help command (#1169)Jertzukka1-1/+2
2023-08-07Call EnsureVisible() for OSX in OnActivate (#1167)Deniz Türkoglu1-0/+1
When using multiple monitors, the resolution can change in OSX, during plug-in/off off the display(s). To avoid window becoming non-usable, there is EnsureVisible, that is called in several places. However, if you minimize VeraCrypt on the bigger screen, and restore it in the main screen of a MacBook, after unplugging, the window will become unusable (unless you know that clicking 'About' calls EnsureVisible :-)). Call EnsureVisible OnActivate so MainFrame is always functional across screens, even when minimized.
2023-08-04fix warnings and UB (#1164)kovalev01-2/+2
* Crypto: fix warning mismatched bound ../Crypto/cpu.c:67:32: warning: argument 2 of type 'uint32[4]' {aka 'unsigned int[4]'} with mismatched bound [-Warray-parameter=] 67 | int CpuId(uint32 input, uint32 output[4]) | ~~~~~~~^~~~~~~~~ In file included from ../Crypto/cpu.c:3: ../Crypto/cpu.h:236:33: note: previously declared as 'uint32 *' {aka 'unsigned int *'} 236 | int CpuId(uint32 input, uint32 *output); Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org> * Core/Unix: fix warning ignoring return value Unix/CoreUnix.cpp: In member function 'virtual std::shared_ptr<VeraCrypt:\ :VolumeInfo> VeraCrypt::CoreUnix::MountVolume(VeraCrypt::MountOptions&)': Unix/CoreUnix.cpp:682:55: warning: ignoring return value of 'int chown(const char*, __uid_t, __gid_t)' declared with attribute 'warn_unused_result' [-Wunused-result] 682 | chown (mountPoint.c_str(), GetRealUserId(), GetRealGroupId()); | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org> * Main/Forms: fix warning cast to pointer from integer of different size Forms/MainFrame.cpp: In member function 'void VeraCrypt::MainFrame:\ :UpdateVolumeList()': Forms/MainFrame.cpp:1718:106: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 1718 | Gui->InsertToListCtrl (SlotListCtrl, ++prevItemIndex, fields, 0, (void *) volume->SlotNumber); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ Forms/MainFrame.cpp:1753:114: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 1753 | Gui->InsertToListCtrl (SlotListCtrl, ++prevItemIndex, fields, 0, (void *) slotNumber); | ^~~~~~~~~~~~~~~~~~~ Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org> * Crypto: fix undefined behavior signed integer overflow In function 'twofish_set_key': cc1: warning: iteration 4 invokes undefined behavior [-Waggressive-loop-optimizations] ../Crypto/Twofish.c:626:23: note: within this loop 626 | for (i = 0; i != 40; i += 2) | ~~^~~~~ Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org> --------- Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org> Co-authored-by: Vasiliy Kovalev <kovalev@altlinux.org>
2023-07-24Linux/macOS: Remove TrueCrypt supportMounir IDRASSI21-191/+59
2023-07-23Linux/macOS:Add EMV option checkbox to the fbp file. Remove TrueCrypt ↵Mounir IDRASSI3-9698/+2294
checkboxes. We also update to wxFormBuilder 3.10.1
2023-07-23Update UserInterface.cpp (#1155)Springfield Data Recovery1-1/+1
Docs specify cascading encryption should be specified as "AES(Twofish)" but on Linux it requires "AES-Twofish".
2023-07-05Linux: Overwriting file container allows you to use its space (#1147)Jertzukka1-0/+6
When replacing a file container, we increase the `diskSpace` by the file container's size. This doesn't affect the hidden volume space logic, as in that case we use `MaxVolumeSize` when `MaxVolumeSizeValid` is true instead of `AvailableDiskSpace`.
2023-06-29Linux: Fix wrong size for hidden volume when selecting the option to use all ↵Mounir IDRASSI1-1/+1
free space (fix by @Jertzukka)
2023-06-29Linux/FreeBSD: Make pcsclite a dependency of the packages and the generic ↵Mounir IDRASSI1-2/+2
installer
2023-06-29EMV keyfile support: Overall code improvements and bug fixesMounir IDRASSI19-103/+135
2023-06-28Add EMV functionality (#1080)mmauv22-74/+219
* Add basic strcture needed for EMV implementation * Add demo EMV functionality with C code pasted in a very dirty and unsafe way. NOT FINAL * Refactor IccExtractor Structure * Fix Makefile * fix include file * move global variables from h to c * revert to memcpy * fix icc data recovery functions * Add EMV functionalities on windows * Make EMVToken structures like SecurityToken * Define constants instead of hard coded values * Token structures created with inheritance * refactor TokenKeyfile to use inherit. + polymor. * add Token.h + Token.cpp in modules in VS2010 * Add a comment at each use of SecurityToken class or objects * SecurityTokenKeyfilesDialog preparation * Implemennt GetAvailableTokens in Token class on windows * merge * up (patching for Windows) * foreach Token.cpp corrected * Display EMV keyfiles on first window in graphic interface * Add token to Windows UI * EMVToken selection on OKButton on Linux * Keyfile.cpp optimization * Move getKeyfileData in the token class * EMV::Token GetAvailableKeyfiles() base * Move getKeyfileData in the token class on unix * Remove test comments * Warnings resolved * RemoveeSecurityTokenLibraryNotInitialized exception if at least one emv token is detected * Adding new files * Remove old files and add the new version to the windows project * Change make_shared to shared_ptr constructor * IccExtractor integration working on linux * Throwing card not EMV execption * catch error when not EMV type in EMVToken::GetAvailableKeyfiles * Change types to compile on windows * list all keyfiles, security keyfiles and emv keyfiles in command line * Change type to be coherent and remove old todo comments * Remove todo comments * Change indentation and resolve a bug from previous commit * Use polymorphism for GetKeyfileData and add export option for EMVTokens on Linux * Linux : Allow to export EMV Tokens in command lines, Windows : Disable the delete button when EMV Keyfiles are selected * Remove SlotId from TokenInfo as it is already in Token * Correct errors on Linux * Disable delete option if one EMV Token is selected on Linux * Fix bug enabling delete button if nothing is selected * emv data used as reference then burnt * use of normal files in linux corrected * help updated * help updated for export functionnality * option EMV added to graphic interface but not yet working * Bug fix : Allow to use multiple EMV on windows * EMV Option added to UserPreferences * EMV Option working for Linux * EMV option added to Windows (not working yet) * [NOT TESTED] EMV option for Windows * Working EMV option on Windows * EMV Option for data extraction working for volume creation * EMV Option for data extraction working for Mount * EMV Option for data extraction working for mounting favorites volumes * EMV Option for extraction working for Changing volume password, Set Derivation Key Algorithm and Add or remove keyfile from volume * Windows : re-checking EMV Option when getting data * Removing error catches in the IccDataExtractor classe (It only throws error now). Changing GetPan signature to resemble the other functions signatures more * Changing EMV errors - Only throwing ICCExtractionException from outside of the ICC module. - Catching all TLVExceptions and PCSCExceptions to throw the right ICCExtractionException - Deleting APDU exceptions. * First version of the documentation * Adding function pointers for winscard library (but it crashes VeraCrypt) * Debugging function pointers * The import of the library on windows work as expected now * Reverting EMVToken.cpp changes used to test to library import * Searching for the System32 path instead of hard codding it * Fixing the bug were VeraCrypt crashes if there is no readers when "add Token files" is clicked * Winscard library not initialized in object constructor anymore to delay it after EMVOption check * Remove winscard lib from windows dependencies * Properly displaying errors * Adding a dot in Language.xml * Catching TLVException * Removing unused code * Remove unusefull comments * Trying to fix 0x1f error * Update IccDataExtractor.cpp * Delete History.xml * Fix get data without get pan * Cleanup code * changes for linux compilation but linking not working * error handling for linux * erasing emv data * Burn PAN * Burn PAN from memory * Uncomment selfcheck before merging master * burn corrected * EMV errors handling for Linux * EMV working for Linux CLI * Doc : Winscard Linux package and VeraCrypt versions --------- Co-authored-by: doriandu45 <d45.poubelle@gmail.com> Co-authored-by: red4game <redemgaiming@gmail.com> Co-authored-by: Brice.Namy <brice.namy@insa-rennes.fr> Co-authored-by: vocthor <pieceo108@gmail.com> Co-authored-by: vocthor <67202139+vocthor@users.noreply.github.com> Co-authored-by: Andrei COCAN <andrei.cocan@insa-rennes.fr> Co-authored-by: AndreiCocan <95496161+AndreiCocan@users.noreply.github.com> Co-authored-by: francoisLEROUX <francois3443@gmail.com>
2023-06-14Linux/macOS: only wipe password/PIM text controls if they are not emptyMounir IDRASSI2-2/+10
This fixes a crash on macOS with latest wxWidgets 3.2.2.1 where GetLineLength returns -1
2023-06-13Linux: Fix compatibility of generic installers with old Linux distrosMounir IDRASSI1-1/+1
In old Linux distributions, tar command doesn't support "--keep-directory-symlink" so we now dynamically detect if this switch is support and then we use it if it is available
2023-06-05Linux/macOS: Fix error during creation of installation packageMounir IDRASSI1-3/+3
"-R" switch was missing from the "cp" command
2023-06-01Fix issues launching fsck via terminal on Linux (#1086)Jertzukka2-0/+3
Currently on a system without xterm or konsole (like fresh Ubuntu install) the fsck check will not launch. Added gnome-terminal as an alternative and fixed an issue where konsole will always error out as --title and --caption are no longer valid arguments. Previously the error message was simply "xterm not found", so new LangString LINUX_EX2MSG_TERMINALNOTFOUND was added to let the user knows which programs they need to get the feature working.
2023-05-27Prevent failing fs options being shown in --text --create (#1078)Jertzukka1-15/+23
Removes the options exFAT and Btrfs being shown when creating a volume in text mode when the system does not support them and will end up erroring out at the end. Hide Btrfs option when the volume is too small, as we will anyways fail right after. Hardcoded numbering changed to dynamic as the available options are not necessarily consecutive.
2023-05-22Linux: Fix printing error when checking freespace during volume creationMounir IDRASSI1-1/+6
No parent directory specified in the path, we assume current directory We first check if parent directory exists before checking its free space using wxgetDiskSpace Based on idea proposed by @bogdro in PR#1025
2023-05-21Linux/macOS: Better handling of wrong PIM value in text mode (enhances PR#1026)Mounir IDRASSI1-1/+4
2023-05-21Keep PIM secret and re-ask when user entered a wrong value (#1026)Bogdan Drozdowski1-1/+5
Co-authored-by: Bogdan Drozdowski <>
2023-05-19wxWidget assert failure bug (#999)Es6-107/+113
* Removal of any of the any of `wxALIGN_RIGHT`/`wxALIGN_CENTRE_HORIZONTAL`/`wxALIGN_BOTTOM`/`wxALIGN_CENTRE_VERTICAL` when used in conjunction with `wxEXPAND` wxWidget has an "assert" that gets triggered anytime `wxEXPAND` gets used with an alignment property (useless override). This leads to a popup backtrace everytime a non-compliant widget is opened. * Removal of missed `wxALIGN_RIGHT`/`wxALIGN_CENTRE_HORIZONTAL`/`wxALIGN_BOTTOM`/`wxALIGN_CENTRE_VERTICAL` when used in conjunction with `wxEXPAND` * Removed property 'label' for wxMenuBar as no longer used (wxFormBuilder) * Removed redundant 'wxALIGN_RIGHT' for the "OK" button in the preference panel (there is a spacer already in-place that pushes the buttons to the right) * Removed redundant 'wxALIGN_RIGHT' for items in the wizard panel's (`WizardFrameBase`) button bar and added width spacing for the 2 spacers between the buttons to make up for the change. * Changed constructor signature for the `WizardPage` and all subclasses The addition of the wxString 'name' arg brings it inline with the new wxFromBuilder v3.10.1 output so that editing+generating the forms from it won't brake the build now. * Removed remaining redundant 'wxALIGN_*' that were paired with 'wxEXPAND'. * Added missing default flags to wxFileName::Normalize(..) method The old empty initialization which was fine up to v2.8.12 of wxWidget gives off a compile warning. Since the default `wxPATH_NORM_ALL` is now depreciated (v3.x) the equivalent individual flags must be explicitly given. * Changed spaces to tabs to bring last commit inline with the rest of the src code
2023-05-18Add a new LangString 'LINUX_VOL_MOUNTED' to show when volume mounted. Fixes ↵Jertzukka1-1/+1
(#1029) the issue of 'LINUX_VOL_DISMOUNTED' being shown even when not dismounting.
2023-05-18Linux/macOS: Suppress asserts displayed by wxWidgets 3.1.6+ for sizer flags ↵Mounir IDRASSI1-0/+1
until we fix all sizer flags in our UI.
2022-08-21Fix incorrect text color in dark mode (#920)Kenneth Chew2-3/+3
2022-02-19Linux/MacOSX: Fix hidden volume settings not correctly displayed when ↵Mounir IDRASSI3-4/+7
enabling hidden volume protection in mount options window
2022-02-11Update copyrights following integration of LZMA SDKMounir IDRASSI1-1/+2
2022-01-08MacOSX: remove write permission also from group on application bundleVeraCrypt_1.25.7Mounir IDRASSI1-1/+1
2022-01-02Update copyright year to 2022Mounir IDRASSI1-2/+2
2021-12-24MacOSX: correct permission of VeraCrypt application bundle during packagingMounir IDRASSI1-0/+1
2021-11-21Linux/macOS/FreeBSD: return error if unknown filesystem value specified in ↵Mounir IDRASSI1-1/+1
--filesystem switch
2021-11-21Linux/FreeBSD: Fix calling "make install" without specifying DESTDIR, which ↵Mounir IDRASSI1-0/+4
should work by installing into /usr
2021-09-21Linux/macOS: Add CLI switch (--size=max) and UI option to give a file ↵Mounir IDRASSI8-74/+268
container all available free space. This commit also makes --size switch accept KiB/MiB/GiB/TiB prefixes and adds TiB choice in UI.
2021-09-04Minor cleanup of the repo (#822)a13460541-0/+0
* *: source files should not be executable * *: make sure files have final newline * *: remove BOM from text files * translations: unify headers * *: fix typos * *: trim excess whitespace
2021-08-30Update copyright year to 2021Mounir IDRASSI1-2/+2
2021-08-21Linux: Better Linux desktop integration. Add mount.veracrypt script for ↵Mounir IDRASSI1-0/+7
fstab (proposed by unit193 at https://github.com/veracrypt/VeraCrypt/issues/814)
2021-08-21Fix typo in GraphicUserInterface.cppMounir IDRASSI1-1/+1
2021-08-21Linux/macOS: print LANG environment variable to console only in DEBUG modeMounir IDRASSI1-0/+2
2021-08-16Add compile-time toggleable support for application indicators, off by ↵Unit 1933-1/+90
default. (#815) This tries to figure out, via wx-config, if you're using GTK2 or GTK3 and uses the associated Ayatana library.
2021-08-15MacOSX: First native Apple M1 supportMounir IDRASSI6-18/+23
2021-07-14Add support for OpenBSD (#779)kokokodak1-1/+1
* OpenBSD: add basic support modified: Build/Include/Makefile.inc modified: Driver/Fuse/FuseService.cpp modified: Main/FatalErrorHandler.cpp modified: Makefile modified: Platform/Unix/File.cpp modified: Platform/Unix/FilesystemPath.cpp modified: Platform/Unix/SystemInfo.cpp * OpenBSD: some necessary files were missing new file: Core/Unix/OpenBSD/CoreOpenBSD.cpp new file: Core/Unix/OpenBSD/CoreOpenBSD.h new file: Core/Unix/OpenBSD/System.h
2021-02-21fix Program freeze Volume Creation Wizard linux (#726)T-Bonhagen2-3/+12
2020-12-20Linux/MacOSX: make LanguageStrings.cpp build depend on Language.xml.h since ↵Mounir IDRASSI1-0/+2
it uses it
2020-12-20Linux: fix build error with old gcc compilers that don't have std::getenvMounir IDRASSI1-1/+1