From 28b20acab0b33f3903b865144eab63103d1e0326 Mon Sep 17 00:00:00 2001 From: Mounir IDRASSI Date: Fri, 30 Aug 2024 15:21:21 +0200 Subject: Wndows: Fix error 1603 returned by MSI silent install when REBOOT=ReallySuppress specified and a reboot is required In this case, installation was done by the customer action VC_CustomAction_DoChecks was returning the error ERROR_INSTALL_FAILURE (1603)nevertheless. Now we return success code correctly. --- src/SetupDLL/Setup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/SetupDLL/Setup.c b/src/SetupDLL/Setup.c index 1c3782dd..e5c3337f 100644 --- a/src/SetupDLL/Setup.c +++ b/src/SetupDLL/Setup.c @@ -3356,6 +3356,7 @@ EXTERN_C UINT STDAPICALLTYPE VC_CustomAction_DoChecks(MSIHANDLE hInstaller) if (bDisableReboot) { MSILog(hInstaller, MSI_INFO_LEVEL, L"VC_CustomAction_DoChecks: reboot is required but it is disabled because \"REBOOT\" specifies ReallySuppress"); + uiRet = ERROR_SUCCESS; } else { -- cgit v1.2.3